Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix test for outdated-new-versions in edge cases #3924

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Member

robertkowalski commented Sep 22, 2013

I noticed that the test for outdated-new-versions.js is not working in two cases:

Make the tests independent from the order of the data-Array which
differs when I run the test as standalone on my OSX machine.

Fix tests which clean cache:

As other tests are using underscore as test-package too and
are using other ports passed to spawn and exec via environment
variable the cached data the tests will fail as they try to
use a cached JSON with the previous registry url that uses
another port.

Fix test for outdated-new-versions in edge cases
Make the tests independent from the order of the data-Array which
differs when I run the test as standalone on my OSX machine.

Fix tests which clean cache:

As other tests are using underscore as test-package too and
are using other ports passed to spawn and exec via environment
variable the cached data the tests will fail as they try to
use a cached JSON with the previous registry url that uses
another port.
Member

domenic commented Sep 28, 2013

LGTM but I cannot merge due to #3948; tagging as ready-to-merge

Member

robertkowalski commented Oct 20, 2013

is also part of isaacs#4001

@robertkowalski robertkowalski deleted the robertkowalski:test-fix-standalone branch Oct 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment