Skip to content

Fix 'weird error'. #3926

Closed
wants to merge 1 commit into from

3 participants

@thomblake

Whenever npm gets an error code that is numeric, it outputs
'weird error' - including practically every instance of running
'npm test'.

This change outputs 'exit code' for numeric errors and 'weird error'
for the remaining cases.

Related: #3918

@thomblake thomblake Fix 'weird error'.
Whenever npm gets an error code that is numeric, it outputs
'weird error' - including practically every instance of running
'npm test'.

This change outputs 'exit code' for numeric errors and 'weird error'
for the remaining cases.

Related: #3918
d229c90
@thomblake

I couldn't think of a reasonable way to add a test for this - I'm open to suggestions or "it's fine without a test".

@luk-
luk- commented Sep 23, 2013

I like it, I want to get isaac's feedback on it when he's back from vacation though before we throw it in

@thomblake

Will instead modify lifecycle.js to handle numeric errors properly and see how that turns out.

@isaacs
npm member
isaacs commented Oct 24, 2013

Fixed on e380dc5. Will be pushed live soon.

@isaacs isaacs closed this Oct 24, 2013
@robertkowalski robertkowalski referenced this pull request Nov 5, 2013
Closed

weird error n #3918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.