Finally all npm tests pass locally on OSX with Node 0.10.20 #3960

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
@davglass
Contributor

davglass commented Oct 2, 2013

Some minor tweaks to make all tests pass locally on my Mac. Windows testing welcome!

  • Set loglevel to silent in prepublish test
  • Upgraded npm-registry-mock to latest for outdated test
  • Used a different mock format for latest npm-registry-mock for ignore-shrinkwrap test
@luk-

This comment has been minimized.

Show comment Hide comment
@luk-

luk- Oct 2, 2013

Contributor

I still seem to get the error in #3948.

npm ERR! Error: ENOENT, open '/var/folders/q0/gjyrqk890xs_3t2vh61n5xz00000gn/T/npm-test-13434/root/lib/package.json'

package.json isn't getting created like it should be, I'll take a look now that I have a few minutes.

Contributor

luk- commented Oct 2, 2013

I still seem to get the error in #3948.

npm ERR! Error: ENOENT, open '/var/folders/q0/gjyrqk890xs_3t2vh61n5xz00000gn/T/npm-test-13434/root/lib/package.json'

package.json isn't getting created like it should be, I'll take a look now that I have a few minutes.

@davglass

This comment has been minimized.

Show comment Hide comment
@davglass

davglass Oct 3, 2013

Contributor

Weird, they all pass locally for me :(

Dav Glass
davglass@gmail.com
blog.davglass.com

  • Windows: n. - The most successful computer virus, ever. +
  • A computer without a Microsoft operating system is like a dog
    without bricks tied to its head +
  • A Microsoft Certified Systems Engineer is to computing what a
    McDonalds Certified Food Specialist is to fine cuisine +
Contributor

davglass commented Oct 3, 2013

Weird, they all pass locally for me :(

Dav Glass
davglass@gmail.com
blog.davglass.com

  • Windows: n. - The most successful computer virus, ever. +
  • A computer without a Microsoft operating system is like a dog
    without bricks tied to its head +
  • A Microsoft Certified Systems Engineer is to computing what a
    McDonalds Certified Food Specialist is to fine cuisine +
@luk-

This comment has been minimized.

Show comment Hide comment
@luk-

luk- Oct 3, 2013

Contributor

Argh.

Contributor

luk- commented Oct 3, 2013

Argh.

@domenic

This comment has been minimized.

Show comment Hide comment
@domenic

domenic Oct 3, 2013

Member

Still having the same error as in #3948.

Member

domenic commented Oct 3, 2013

Still having the same error as in #3948.

@luk-

This comment has been minimized.

Show comment Hide comment
@luk-

luk- Oct 3, 2013

Contributor

@davglass if you do a fresh clone of your branch and run npm test do they still pass?

Contributor

luk- commented Oct 3, 2013

@davglass if you do a fresh clone of your branch and run npm test do they still pass?

@davglass

This comment has been minimized.

Show comment Hide comment
@davglass

davglass Oct 3, 2013

Contributor

Here are my steps:

git clone davglass/npm
cd npm
git checkout -b moretests origin/moretests
node ./cli.js install
node ./cli.js test

All tests pass..

Contributor

davglass commented Oct 3, 2013

Here are my steps:

git clone davglass/npm
cd npm
git checkout -b moretests origin/moretests
node ./cli.js install
node ./cli.js test

All tests pass..

@robertkowalski

This comment has been minimized.

Show comment Hide comment
@robertkowalski

robertkowalski Oct 3, 2013

Member

@davglass that's odd, still getting the error.

Member

robertkowalski commented Oct 3, 2013

@davglass that's odd, still getting the error.

@davglass

This comment has been minimized.

Show comment Hide comment
@davglass

davglass Oct 3, 2013

Contributor

Man, these all passed on my three dev machines yesterday (2 OSX and 1 Linux). Today I'm getting a new error:

https://gist.github.com/davglass/6814837

Contributor

davglass commented Oct 3, 2013

Man, these all passed on my three dev machines yesterday (2 OSX and 1 Linux). Today I'm getting a new error:

https://gist.github.com/davglass/6814837

@davglass

This comment has been minimized.

Show comment Hide comment
@davglass

davglass Oct 3, 2013

Contributor

Seems to be some issue here, this test will fail but if you run it more than once by itself it will pass and continue to pass from the main tests:

node ./test/tap/outdated-new-versions

Contributor

davglass commented Oct 3, 2013

Seems to be some issue here, this test will fail but if you run it more than once by itself it will pass and continue to pass from the main tests:

node ./test/tap/outdated-new-versions

@robertkowalski

This comment has been minimized.

Show comment Hide comment
@robertkowalski

robertkowalski Oct 3, 2013

Member

yes, this gets fixed by isaacs#3924 but the merge is blocked by the error from #3948.

Member

robertkowalski commented Oct 3, 2013

yes, this gets fixed by isaacs#3924 but the merge is blocked by the error from #3948.

@domenic

This comment has been minimized.

Show comment Hide comment
@domenic

domenic Oct 10, 2013

Are we sure this doesn't defeat the purpose of the test?

Are we sure this doesn't defeat the purpose of the test?

This comment has been minimized.

Show comment Hide comment
@davglass

davglass Oct 10, 2013

Owner

I'm pretty sure it doesn't defeat the test, the issue is that the npm logging is sending data to stderr and the test is expecting nothing on stderr unless there is an actual error.

If you change the 'pack' command to 'pack2' then the test will fail since it's throwing an actual error to stderr

Owner

davglass replied Oct 10, 2013

I'm pretty sure it doesn't defeat the test, the issue is that the npm logging is sending data to stderr and the test is expecting nothing on stderr unless there is an actual error.

If you change the 'pack' command to 'pack2' then the test will fail since it's throwing an actual error to stderr

This comment has been minimized.

Show comment Hide comment
@domenic

domenic Oct 10, 2013

Right I just thought that the purpose of the test was to compare "correct" stderr log output to actual stderr log output. But I think I am wrong because even with these changes the test still fails on my system with the \n vs. \r\n problem, so there must be some other output being tested.

Right I just thought that the purpose of the test was to compare "correct" stderr log output to actual stderr log output. But I think I am wrong because even with these changes the test still fails on my system with the \n vs. \r\n problem, so there must be some other output being tested.

@domenic

This comment has been minimized.

Show comment Hide comment
@domenic

domenic Nov 26, 2013

Member

Seems like we got this merged, let me know if I'm mistaken.

Member

domenic commented Nov 26, 2013

Seems like we got this merged, let me know if I'm mistaken.

@domenic domenic closed this Nov 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment