Skip to content

cannot use the custom registry whose port is not 80 because of the invalid 'Host' header. #726

Closed
wants to merge 1 commit into from

2 participants

@yssk22
yssk22 commented Mar 20, 2011

Hello,

I set up my local npm registry referring to https://github.com/isaacs/npmjs.org .
I could be able to deploy couchapp and replicate documents from the public registry
to the my local npm registry (http://localhost:5984/npm).
But I can not use registry operation commands such as npm publish, npm install, ... etc
with '--registry http://localhost:5984/' option.

I found that the latest npm (0.3.5) did not set the correct 'Host' header if the port of the given registry is not 80, so that registry rewrite rules were ignored.

I send you the fix patch for this issue.
Could you please confirm and merge it?

Thanks.

@isaacs
npm member
@isaacs isaacs closed this Mar 20, 2011
@yssk22 yssk22 reopened this Mar 21, 2011
@yssk22
yssk22 commented Mar 21, 2011

Sorry, this error occurs on 0.3.15, and I also found the error on 0.3.16.

the patch is for the commit 100f137.

@isaacs
npm member
isaacs commented Mar 21, 2011

Closed by cca69c9465a8fb98789897ab67393564226722cf Put port on hostname.

@isaacs isaacs closed this Mar 21, 2011
@indexzero indexzero pushed a commit that referenced this pull request Apr 19, 2011
@isaacs isaacs Closes GH-726 Put port on hostname. b8698c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.