[npm@3] Use the progress bar only with quiet logging levels #9240

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@saper
Contributor
saper commented Aug 11, 2015

Adding -d or -ddd to npm invocation
causes a strange mix of the progress bar
along with the verbose output.

@saper saper changed the title from Use progress barn only with the default loglevel to [npm@3] Use the progress bar only with the default loglevel Aug 11, 2015
@saper saper changed the title from [npm@3] Use the progress bar only with the default loglevel to [npm@3] Use the progress bar only with quiet logging levels Aug 11, 2015
@iarna iarna was assigned by othiym23 Aug 11, 2015
@othiym23 othiym23 added the review label Aug 11, 2015
@saper
Contributor
saper commented Aug 17, 2015

Might improve #8812 a bit.

@iarna
Member
iarna commented Aug 24, 2015

You link to 8812, so maybe I'm not understanding the problem you're seeing? Can you describe that a bit more?

For me I get the log scrolling in the window and a progress bar at the bottom. It sometimes isn't visible when there's a lot of stuff being printed, but when it slows down the progress bar is visible, and when the install finishes it goes away. This all seems fine to me…

Is that not what you're seeing?

@saper
Contributor
saper commented Aug 24, 2015

I think this is really related to #9313. It looks like this: silly messages scroll off the screen - and to the right of every message there is a piece of progress bar attached.

It shows my age but I dislike vt control sequences in the output because I am very often using script(1) or excellent GNU screen logging facility to capture my work (batch or interactive) to be able to troubleshoot problems later.

Processing/analyzing a log full of vt sequences is cumbersome (yes, I know how to strip the sequences or use less -R...), so I set color=false by default.

@othiym23 othiym23 added this to the 3.x milestone Aug 24, 2015
@saper saper Use progress bar only with non-verbose output
Adding -d or -ddd to npm invocation
causes a strange mix of the progress bar
along with the verbose output.

Display progress bar only with
'warn', 'silent' or 'error' log levels.
31331fa
@iarna
Member
iarna commented Sep 8, 2015

I'm going to close this, because between --no-progress and --no-color I think the problem here is adequately addressed. Plus we WILL be fixing #9313.

@iarna iarna closed this Sep 8, 2015
@iarna iarna removed the review label Sep 8, 2015
@saper
Contributor
saper commented Sep 8, 2015

Thanks, this was opened before I have identified #9313 as a probable cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment