This repository has been archived by the owner. It is now read-only.

Elminate warnings about missing package.json at top level #9343

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@iarna
Member

iarna commented Aug 19, 2015

npm@2 didn't emit these and to be honest, it's not that interesting. The test change actually just reverts a previous test change when these warnings were introduced.

This will half fix #9113

@iarna iarna added the in-progress label Aug 19, 2015

@iarna iarna added this to the 3.x-next milestone Aug 19, 2015

@@ -146,7 +146,8 @@ function getLite (data, noname) {
lite.problems.push('extraneous: ' + getPackageId(data) + ' ' + (data.path || ''))
}
if (data.error && data.path !== path.resolve(npm.globalDir, '..')) {
if (data.error && data.path !== path.resolve(npm.globalDir, '..') &&
(data.error.code !== 'ENOENT' || noname)) {

This comment has been minimized.

@iarna

iarna Aug 19, 2015

Member

add (or verify exists) a test that DOES trigger an error at the bottom from a top level package. Invalid package.json.

@iarna

iarna Aug 19, 2015

Member

add (or verify exists) a test that DOES trigger an error at the bottom from a top level package. Invalid package.json.

@othiym23

This comment has been minimized.

Show comment
Hide comment
@othiym23

othiym23 Aug 19, 2015

Contributor

Reviewed by me via ScreenHero, with the suggestion of adding a sad path test. 🐑 once that's added.

Contributor

othiym23 commented Aug 19, 2015

Reviewed by me via ScreenHero, with the suggestion of adding a sad path test. 🐑 once that's added.

iarna added a commit that referenced this pull request Aug 20, 2015

iarna added a commit that referenced this pull request Aug 21, 2015

@iarna iarna added ready and removed in-progress labels Aug 21, 2015

Show outdated Hide outdated test/tap/ls-top-errors.js Outdated

iarna added a commit that referenced this pull request Aug 21, 2015

@othiym23

This comment has been minimized.

Show comment
Hide comment
@othiym23

othiym23 Aug 28, 2015

Contributor

Landed as 02420dc. It's fitting that these trees are getting "elminated"! Thanks, Rebecca!

Contributor

othiym23 commented Aug 28, 2015

Landed as 02420dc. It's fitting that these trees are getting "elminated"! Thanks, Rebecca!

@othiym23 othiym23 closed this Aug 28, 2015

@iarna iarna deleted the iarna/fix-top-level-errors branch Sep 9, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.