Report error gracefully with invalid URL format dependencies #9480

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@jamietre
Contributor
jamietre commented Sep 3, 2015

Resolves issue #9433

@othiym23 othiym23 added this to the 3.x-next-next milestone Sep 8, 2015
@othiym23 othiym23 added the review label Sep 8, 2015
@iarna
Member
iarna commented Sep 14, 2015

I've reviewed this, it looks great! Thank you! I've made two small changes, first, we've been prefixing the commit message w/ the thing it modifies. And second, we use a small module called iferr to explicitly route error conditions in scenarios like this. You can see the version I'm planning to land below:

7c39f4f

@jamietre
Contributor

Makes sense, glad to know about the conventions. Thanks!

@iarna
Member
iarna commented Sep 17, 2015

Thanks again for this, it's live with npm@3.3.4

@iarna iarna closed this Sep 17, 2015
@iarna iarna removed the review label Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment