This repository has been archived by the owner. It is now read-only.

make tests always use right node + npm #9982

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@iarna
Member

iarna commented Oct 15, 2015

Our test lifecycles regularly run npm commands as a part of them– this patch ensures that they're run with the same npm and node that the original was run.

@iarna iarna added this to the next-next-3 milestone Oct 15, 2015

@othiym23

This comment has been minimized.

Show comment
Hide comment
@othiym23

othiym23 Oct 22, 2015

Contributor

Reviewed in person: 🐑

Contributor

othiym23 commented Oct 22, 2015

Reviewed in person: 🐑

iarna added a commit that referenced this pull request Oct 22, 2015

iarna added a commit that referenced this pull request Oct 22, 2015

iarna added a commit that referenced this pull request Oct 22, 2015

@iarna

This comment has been minimized.

Show comment
Hide comment
@iarna

iarna Oct 23, 2015

Member

This landed in 3.3.10.

Member

iarna commented Oct 23, 2015

This landed in 3.3.10.

@iarna iarna closed this Oct 23, 2015

@iarna iarna removed the in-progress label Oct 23, 2015

@iarna iarna deleted the iarna/make-tests-always-use-right-npm branch Oct 28, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.