make tests always use right node + npm #9982

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@iarna
Member
iarna commented Oct 15, 2015

Our test lifecycles regularly run npm commands as a part of them– this patch ensures that they're run with the same npm and node that the original was run.

@iarna iarna added the in progress label Oct 15, 2015
@iarna iarna referenced this pull request in nodejs/node Oct 15, 2015
Closed

test: update test-npm to work with npm 3 #3308

iarna added some commits Oct 15, 2015
@iarna iarna test: Use the version of node and npm being tested to do setup a9a881c
@iarna iarna test: clear npm user agent to eliminate false positive in installable…
… check
1d2843a
@iarna iarna package: Add a test-node script for testing from node.js
32d46f1
@iarna iarna added this to the next-next-3 milestone Oct 15, 2015
@othiym23
Contributor

Reviewed in person: 🐑

@iarna iarna added a commit that referenced this pull request Oct 22, 2015
@iarna iarna test: clear npm user agent to eliminate false positive in installable…
… check

PR-URL: #9982
842965e
@iarna iarna added a commit that referenced this pull request Oct 22, 2015
@iarna iarna package: Add a test-node script for testing from node.js
PR-URL: #9982
fde6477
@iarna
Member
iarna commented Oct 23, 2015

This landed in 3.3.10.

@iarna iarna closed this Oct 23, 2015
@iarna iarna removed the in progress label Oct 23, 2015
@iarna iarna deleted the iarna/make-tests-always-use-right-npm branch Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment