Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add noproxy configuration #13

Closed
wants to merge 20 commits into from

8 participants

@vvision

Here is the pull request concerning the modification needed for implementing the noproxy configuration as defined here: npm/npm#2873

isaacs and others added some commits
@isaacs isaacs loosen nopt dep 48d9ebf
@isaacs isaacs v0.0.17 d5cb647
@jhs jhs Add platform and arch to the default user-agent 8edbe52
@isaacs isaacs v0.0.18 0621144
@isaacs isaacs Don't use a shared tmp dir in homeless envs
Addresses npm/npm#3064
7b8b800
@isaacs isaacs v0.0.19 92f726d
@isaacs isaacs v0.0.20 41ae994
@luk- luk- adds semver to dependencies
config-defs.js requires semver but the module is not in the deps.
This is probably not an issue with the way npm uses it but it's
causing a problem when using npmconf and npm-registry-client
separately. Added the same version used by npm-registry-client.
d6dd1cb
@rhoot rhoot Adding bin-links
Adding "bin-links" option to support npm/npm#3090.
Setting it to false will prevent npm from making any symlinks to
binaries when using the "npm install" or "npm link" commands.
d53abb8
@isaacs isaacs v0.0.21 8785c2a
@robashton robashton Added missing ini dependency 2d7f2c0
@isaacs isaacs v0.0.22 485865f
@isaacs isaacs cache-min: Default to 10s 5ad935f
@isaacs isaacs v0.0.23 4142156
@vvision vvision Merge remote-tracking branch 'upstream/master'
Conflicts:
	config-defs.js
	package.json
7b95ea4
@vvision vvision Merge branch 'master' of github.com:vvision/npmconf 20feec0
@vvision vvision Fixed indentation. a3c93ba
@jmaxxz

Is there any hope of this ever going in? A noproxy option is really needed.

@othiym23
Owner

Two things:

  1. This repo is deprecated, because the code has been merged back into npm core. Given the heavy dependencies between npm and npmconf, it really didn't make sense for npmconf to be a freestanding thing.
  2. It turned out that the easiest way to support this behavior was via the semi-standard NO_PROXY environment variable, and to implement it in request as part of its proxy and tunneling agent support. This was done a few months ago, so recent versions of npm (including npm@2.5.1, the latest stable version, which is bundled with Node 0.12.0 and io.js 1.2.0) have support for NO_PROXY included.

This probably won't be added as config to npm unless and until request makes that functionality configurable, and even then messing with how the proxy support works makes me very nervous, because it is hard to test, which makes it brittle.

@othiym23 othiym23 closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 11, 2012
  1. @vvision

    Added no-proxy config.

    vvision authored
Commits on Oct 16, 2012
  1. @vvision

    Renamed no-proxy into noproxy.

    vvision authored
Commits on Mar 19, 2013
  1. @vvision
Commits on Sep 23, 2014
  1. @isaacs @vvision

    loosen nopt dep

    isaacs authored vvision committed
  2. @isaacs @vvision

    v0.0.17

    isaacs authored vvision committed
  3. @jhs @vvision

    Add platform and arch to the default user-agent

    jhs authored vvision committed
  4. @isaacs @vvision

    v0.0.18

    isaacs authored vvision committed
  5. @isaacs @vvision

    Don't use a shared tmp dir in homeless envs

    isaacs authored vvision committed
    Addresses npm/npm#3064
  6. @isaacs @vvision

    v0.0.19

    isaacs authored vvision committed
  7. @isaacs @vvision

    v0.0.20

    isaacs authored vvision committed
  8. @luk- @vvision

    adds semver to dependencies

    luk- authored vvision committed
    config-defs.js requires semver but the module is not in the deps.
    This is probably not an issue with the way npm uses it but it's
    causing a problem when using npmconf and npm-registry-client
    separately. Added the same version used by npm-registry-client.
  9. @rhoot @vvision

    Adding bin-links

    rhoot authored vvision committed
    Adding "bin-links" option to support npm/npm#3090.
    Setting it to false will prevent npm from making any symlinks to
    binaries when using the "npm install" or "npm link" commands.
  10. @isaacs @vvision

    v0.0.21

    isaacs authored vvision committed
  11. @robashton @vvision

    Added missing ini dependency

    robashton authored vvision committed
  12. @isaacs @vvision

    v0.0.22

    isaacs authored vvision committed
  13. @isaacs @vvision

    cache-min: Default to 10s

    isaacs authored vvision committed
  14. @isaacs @vvision

    v0.0.23

    isaacs authored vvision committed
  15. @vvision

    Merge remote-tracking branch 'upstream/master'

    vvision authored
    Conflicts:
    	config-defs.js
    	package.json
  16. @vvision
  17. @vvision

    Fixed indentation.

    vvision authored
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 0 deletions.
  1. +2 −0  config-defs.js
View
2  config-defs.js
@@ -182,6 +182,7 @@ Object.defineProperty(exports, "defaults", {get: function () {
, long : false
, message : "%s"
, "node-version" : process.version
+ , "noproxy" : process.env.NO_PROXY || process.env.no_proxy || ""
, npat : false
, "onload-script" : false
, optional: true
@@ -284,6 +285,7 @@ exports.types =
, long : Boolean
, message: String
, "node-version" : [null, semver]
+ , "noproxy" : String
, npat : Boolean
, "onload-script" : [null, String]
, optional: Boolean
Something went wrong with that request. Please try again.