EventEmitter memory leak #11

Closed
wants to merge 1 commit into from

2 participants

@alex-seville

pipe() from mute-stream is called each time Read runs, but the mute-stream is never closed, so if you call Read more than 11 times node throws an EventEmitter memory leak warning onto the console. I think adding a call to end() of mute-stream in done() would resolve the issue.

@isaacs isaacs added a commit that closed this pull request Aug 12, 2012
@isaacs isaacs End mute stream so it un-pipes
Fix #11
f3fbf9a
@isaacs isaacs closed this in f3fbf9a Aug 12, 2012
@isaacs
npm member

Fixed on f3fbf9a. (Had to do a few other things as well as end(), and also added a test.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment