Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Multiple Funding Sources #68

Merged
merged 2 commits into from Feb 5, 2020
Merged

Conversation

@ljharb
Copy link
Contributor

ljharb commented Nov 19, 2019

What / Why

Allow the funding field, which currently can contain a string or an object, to contain an array of those things as well.

See the document for more details.

@ljharb

This comment has been minimized.

Copy link
Contributor Author

ljharb commented Nov 26, 2019

@mikemimik i'd love to get this approved and into 6.14 (happy to do the implementation PR myself); will there be time, assuming it's approved in the meeting tomorrow?

@mikemimik

This comment has been minimized.

Copy link
Contributor

mikemimik commented Nov 26, 2019

@ljharb provided it gets accepted tomorrow, of course we can get this in! If you've got time to implement, then that pull-request would be welcomed with open arms. 👍

@ljharb ljharb force-pushed the ljharb:multiple-funding-sources branch from 7ff7a55 to acda17f Jan 27, 2020
ljharb added a commit to ljharb/cli that referenced this pull request Jan 27, 2020
@ljharb

This comment has been minimized.

Copy link
Contributor Author

ljharb commented Jan 27, 2020

This RFC has been updated, and I've filed npm/cli#731 to implement the feature (under the presumption that this RFC will be accepted and merged in the next RFC call, absent any objections)

ljharb added a commit to ljharb/cli that referenced this pull request Jan 27, 2020
ljharb added a commit to ljharb/cli that referenced this pull request Jan 27, 2020
ljharb added a commit to ljharb/cli that referenced this pull request Jan 28, 2020
@darcyclarke darcyclarke merged commit 116a216 into npm:latest Feb 5, 2020
@ljharb ljharb deleted the ljharb:multiple-funding-sources branch Feb 5, 2020
ljharb added a commit to ljharb/cli that referenced this pull request Feb 19, 2020
@darcyclarke darcyclarke removed the Agenda label Feb 19, 2020
ljharb added a commit to ljharb/cli that referenced this pull request Feb 19, 2020
darcyclarke added a commit to npm/cli that referenced this pull request Feb 25, 2020
See npm/rfcs#68

PR-URL: #731
Credit: @
Close: #731
Reviewed-by: @darcy Clarke

## Prior Art

- The `repository` field works in this same manner; it can be a string, an object, or an array of either.

This comment has been minimized.

Copy link
@tunnckoCore

tunnckoCore Feb 25, 2020

Huh, definitely didn't know that! Cool. But in same time, what's the use case for array? And I'm curious how this will be shown in the npm page :D

This comment has been minimized.

Copy link
@ljharb

ljharb Feb 25, 2020

Author Contributor

@tunnckoCore see the RFC; but i have 200+ packages, all of which could have both the same Github Sponsors URL for me personally, and a unique Tidelift URL for the package.

It's up to npm to decide how it shows on the website; hopefully I get the chance to weigh in before they launch a change :-D

This comment has been minimized.

Copy link
@tunnckoCore

tunnckoCore Feb 26, 2020

That's clear, i value that. I asked about the repository field, because didn't know it support an array.

This comment has been minimized.

Copy link
@ljharb

ljharb Feb 26, 2020

Author Contributor

In that case this might be a mistake on my part :-) https://docs.npmjs.com/files/package.json#repository says it can be a string or an object; I was thinking of the "author" field (which is also string or object) vs the "contributors" field (which is an array of strings-or-objects).

This comment has been minimized.

Copy link
@tunnckoCore

tunnckoCore Feb 26, 2020

Hahaa. Good catch, huh?

Cool, everything is clear now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.