New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive Charts post contains onresize error #45

Closed
geraldarthur opened this Issue Sep 3, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@geraldarthur
Contributor

geraldarthur commented Sep 3, 2014

Caught an error when I was reading over some documentation on responsive charts.

window.onresize(drawGraphic) returns an error since onresize is an object, not a function. It should look something like window.onresize = drawGraphic—however that's not scoped quite right and onresize doesn't fire.

Possible next steps might be removing that section if you want to keep the post focused on using responsive charts with pym.js

cc @alykat

@alykat alykat self-assigned this Sep 3, 2014

@geraldarthur

This comment has been minimized.

Show comment
Hide comment
@geraldarthur

geraldarthur Sep 3, 2014

Contributor

correction: onresize does fire, but isn't setup in the current docs to resize

Contributor

geraldarthur commented Sep 3, 2014

correction: onresize does fire, but isn't setup in the current docs to resize

@alykat

This comment has been minimized.

Show comment
Hide comment
@alykat

alykat Sep 3, 2014

Member

Thanks for spotting this. Better version of the pym-less JS: https://github.com/nprapps/pym.js/blob/master/examples/graphic-onresize/js/graphic.js

Member

alykat commented Sep 3, 2014

Thanks for spotting this. Better version of the pym-less JS: https://github.com/nprapps/pym.js/blob/master/examples/graphic-onresize/js/graphic.js

@geraldarthur

This comment has been minimized.

Show comment
Hide comment
@geraldarthur

geraldarthur Sep 3, 2014

Contributor

tested it and it looks good 👍

many thanks!

Contributor

geraldarthur commented Sep 3, 2014

tested it and it looks good 👍

many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment