Fix global leaks and lint errors #51

Merged
merged 2 commits into from Dec 16, 2012

Conversation

Projects
None yet
4 participants
@despairblue

css, cssRule and cssFile were leaked.

I alos fixed various lint errors in detector.js

@knpwrs

This comment has been minimized.

Show comment Hide comment
@knpwrs

knpwrs Dec 15, 2012

Are these changes going to be published in the Chrome store? I'm still having issues related to these global leaks.

knpwrs commented Dec 15, 2012

Are these changes going to be published in the Chrome store? I'm still having issues related to these global leaks.

nqbao added a commit that referenced this pull request Dec 16, 2012

Merge pull request #51 from despairblue/master
Fix global leaks and lint errors

@nqbao nqbao merged commit a71cc91 into nqbao:master Dec 16, 2012

@nqbao

This comment has been minimized.

Show comment Hide comment
@nqbao

nqbao Dec 16, 2012

Owner

Thanks!

Owner

nqbao commented Dec 16, 2012

Thanks!

@keithamus

This comment has been minimized.

Show comment Hide comment
@keithamus

keithamus May 13, 2013

Just been hit by this. Could we get a v0.2.14 release which includes these?

Just been hit by this. Could we get a v0.2.14 release which includes these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment