New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry errors when pyramid or prism is inscribed in composite geometry #106

Closed
mchamberland opened this Issue Jun 10, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@mchamberland
Contributor

mchamberland commented Jun 10, 2016

Another CD geometry error issue from me, what a surprise!

Create a prism or a pyramid. Inscribe it in a CD geometry (for example, use a box as the base). Envelope the CD geometry in a box. Look at the geometry in egs_view and you'll notice tons of geometry errors. See the input files for tutor7pp below.

I know where the code is getting confused: when a particle is sitting on one of the sides of the prism or pyramid (type EGS_Polygon) and leaving the CD geometry. The howfar of CD geometry somehow does not catch this. My problem is that I find the EGS_Polygon's howfar method hard to read through and understand what's going on, so if someone else wants to tackle this case, be my guest.

prism_cdgeom_errors.txt
pyramid_cdgeom_errors.txt

@mchamberland mchamberland changed the title from Geometry errors when pyramid or prism is inscribed in CD geometry to Geometry errors when pyramid or prism is inscribed in composite geometry Jun 27, 2016

@mchamberland

This comment has been minimized.

Contributor

mchamberland commented Jun 27, 2016

So it turns out that this issue is not limited to CD geometries. It affects any composite geometry with prisms or pyramids: CD, envelope, and union. See the simple geometry file below and the symptoms of geometry errors in egs_view. The geometry is simply the union of a prism and a box.

Anything I can do to help get this fixed? I know my way around a debugger, but as I wrote in the original report, I'm getting lost in the polygon's howfar routine.
prism_union.txt
prism_union

@gwu-reflexionmedical

This comment has been minimized.

gwu-reflexionmedical commented Jul 9, 2016

I had the same problem. What I did was using CD in the last step, and avoid CD after another CD in a different direction.

@ftessier ftessier added the bug label Jul 29, 2016

rtownson added a commit that referenced this issue Sep 8, 2016

Fix #106: geometry errors in pyramid and polygon
Fix floating point errors in pyramid, prism and polygon.
Also fix a bug in EGS_Projector:getProjection(), where
the projection of a vector onto a plane was not calculated
correctly.

ftessier added a commit that referenced this issue Jan 19, 2017

Fix #106: geometry errors in pyramid and polygon
Fix floating point errors in pyramid, prism and polygon.
Also fix a bug in EGS_Projector:getProjection(), where
the projection of a vector onto a plane was not calculated
correctly.

ftessier added a commit that referenced this issue Jan 19, 2017

Fix #106: geometry errors in pyramid and polygon
Fix floating point errors in pyramid, prism and polygon.  Also fix a bug
in EGS_Projector:getProjection(), where the projection of a vector onto
a plane was not calculated correctly.

ftessier added a commit that referenced this issue Jan 19, 2017

Fix #106: geometry errors in pyramid and polygon
Fix floating point errors in pyramid, prism and polygon.  Also fix a bug
in EGS_Projector:getProjection(), where the projection of a vector onto
a plane was not calculated correctly.

ftessier added a commit that referenced this issue Jan 20, 2017

Fix #106: geometry errors in pyramid and polygon
Fix floating point errors in pyramid, prism and polygon. Also fix a bug
in EGS_Projector:getProjection(), where the projection of a vector onto
a plane was not calculated correctly.

ftessier added a commit that referenced this issue Jan 20, 2017

Fix #106: geometry errors in pyramid and polygon
Fix floating point errors in pyramid, prism and polygon. Also fix a bug
in EGS_Projector:getProjection(), where the projection of a vector onto
a plane was not calculated correctly.
@rtownson

This comment has been minimized.

Contributor

rtownson commented Jan 23, 2017

Fixed in release-2017.

@rtownson rtownson closed this Jan 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment