Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mouse issues in terminal pane #17

Merged
merged 2 commits into from Oct 31, 2018

Conversation

@jnpr-raylam
Copy link
Contributor

jnpr-raylam commented Oct 30, 2018

Fix issue nre-learning/antidote#105

Currently mouse events only acting on last tab, so non-last tab cannot use mouse to scroll up/down
The cause is the closure function in javascript for registering events is using outside loop variable.
Explicitly copying the variable to fix it.

@Mierdin Mierdin changed the title Fix issue nre-learning/antidote#105 Fix mouse issues in terminal pane Oct 30, 2018
Copy link
Member

Mierdin left a comment

@jnpr-raylam Awesome! See my suggestion on the CHANGELOG, but otherwise LGTM

CHANGELOG.md Show resolved Hide resolved
@Mierdin Mierdin merged commit 920f1b2 into nre-learning:master Oct 31, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.