Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: strict tsconfig #60

Open
wants to merge 9 commits into
base: master
from

Conversation

@Julusian
Copy link
Collaborator

commented Oct 8, 2019

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    This enables some stricter typescript rules. Primarily to enable strictPropertyInitialization to ensure that all class properties are initialised before they can be used.

  • What is the current behavior? (You can also link to an open issue here)

Typescript is a bit loose in its checks, so some fields can be undefined even though their typings do not indicate that.

  • Other information:

Every command class had to be refactored to allow the typings to work. AbstractCommand has been replaced with a couple of separate base classes & interfaces. Different for each of serializable and deserializable commands.
Other benefits of this is that various properties are now readonly when possible, and there is less dependencies on ensuring 'random' properties are set at the right points.

This makes #55 redundant, as it is enforced that the properties object is defined, and to an acceptable level.

Note: This needs some serious testing, I have not yet run it against an atem, only verified that the tests pass, so it is likely that a bunch of stuff has been broken

Julusian added 4 commits Oct 7, 2019
wip
@Julusian Julusian requested a review from baltedewit Oct 8, 2019
@@ -213,7 +213,8 @@ export enum TransferMode {
NoOp,
Write,
Clear,
WriteAudio = 256
WriteAudio = 256,
TEST = 0x0201

This comment has been minimized.

Copy link
@Julusian

Julusian Oct 18, 2019

Author Collaborator

remove this multiviewer value

Julusian added 5 commits Oct 22, 2019
… mask). Returns true if anything was changed
…kFlags (when appropriate)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.