Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lookahead transitions respect prev_full class #101

Merged
merged 3 commits into from Oct 2, 2019

Conversation

@baltedewit
Copy link
Collaborator

commented Sep 27, 2019

This fix makes lookahead respect a class from the Previous Part such that a transition can be enabled.

I've noticed that when Parts are played out of order the lookahead will "forget" what part was before the current part and it will remove the transition right before actually playing and then add it back when sending the play command. I haven't quite looked into what happens there, but I think in the current implementation of lookahead that's reasonable limitation and won't happen when parts are nicely played in order.

@baltedewit baltedewit requested a review from Julusian Sep 27, 2019
Copy link
Collaborator

left a comment

I'm not 100% happy with it, but doing it better requires some much larger changes. This will be fine until we can do the larger transition overhaul

@Julusian Julusian changed the base branch from release12 to release13 Oct 2, 2019
@Julusian Julusian merged commit 323e489 into release13 Oct 2, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: tests Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.