Some improvements for donate bitcoin #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid Synchronous XMLHttpRequest on the main thread - Make self-contained functions - Rename the qrcode div to avoid clashes between element id and function name - Fail gracefuly when user input can not be handled - Add a default amount that is displayed on first load
|
Thanks for you contributions! I made a few fixes, and have committed them. (I can add you to the credits if you want.) Here is a preview of it in action: https://donate.nrobinson2000.me/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the code in order to:
This is addressing esaezgil/esaezgil.github.io#2