/donate-bitcoin

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements for donate bitcoin #1

Merged
merged 1 commit into from Nov 2, 2017
+81 −32

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@esaezgil @nrobinson2000
@esaezgil
Contributor

esaezgil commented Nov 2, 2017

Refactor the code in order to:

  • Avoid Synchronous XMLHttpRequest on the main thread
  • Make self-contained functions
  • Rename the qrcode div to avoid clashes between element id and function name
  • Fail gracefuly when user input can not be handled
  • Add a default amount that is displayed on first load
  • Start improving code style

This is addressing esaezgil/esaezgil.github.io#2
@esaezgil
Refactor the code in order to: 
 - Avoid Synchronous XMLHttpRequest on the main thread
 - Make self-contained functions
 - Rename the qrcode div to avoid clashes between element id and function name
 - Fail gracefuly when user input can not be handled
 - Add a default amount that is displayed on first load
8922c17

@nrobinson2000 nrobinson2000 merged commit a1b5b56 into nrobinson2000:master Nov 2, 2017

@nrobinson2000

This comment has been minimized.

Sign in to view
Owner

nrobinson2000 commented Nov 3, 2017

Thanks for you contributions!

I made a few fixes, and have committed them. (I can add you to the credits if you want.)

Here is a preview of it in action: https://donate.nrobinson2000.me/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment