Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add road types: triangle and bump #5

Merged
merged 4 commits into from Aug 12, 2019

Conversation

@clemens-tolboom
Copy link
Contributor

commented Jul 30, 2019

I wanted to see what would happen on a triangular road and semi triangular (bump + flat)

Triagle

triagle

Bump

bump

example.py Outdated
@@ -44,6 +44,9 @@ def simulate(car, time_step=0.0002, interval=1):

if __name__ == "__main__":
car = Car()
# road = Road(length= 6, mode="triagle", frequency=1.8, amplitude= 0.1)

This comment has been minimized.

Copy link
@clemens-tolboom

clemens-tolboom Jul 31, 2019

Author Contributor

This needs x_min like below

    road = Road(length= 6, x_min=-3, mode="triagle", frequency=1.8, amplitude= 0.1)
    car = Car(road_func=road)

This comment has been minimized.

Copy link
@nrsyed

nrsyed Aug 5, 2019

Owner

Please see comment on PR #4 (#4 (comment)) on default and hard-coded Road length and x_min values.

This comment has been minimized.

Copy link
@clemens-tolboom

clemens-tolboom Aug 6, 2019

Author Contributor

I closed #4 in favour of this #5 as it is needed here to make this PR work.

halfcar/road.py Outdated Show resolved Hide resolved
halfcar/road.py Outdated Show resolved Hide resolved
@nrsyed
Copy link
Owner

left a comment

Very nice, I like the triangle and bump road profiles. Please see comments for issues to discuss/address before ready for merging.

@clemens-tolboom clemens-tolboom force-pushed the clemens-tolboom:feature/add-road-types branch from c04ef8c to e961c2c Aug 5, 2019

halfcar/road.py Outdated Show resolved Hide resolved
@clemens-tolboom

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

I still have trouble with fixing #4. I'll try to fix this week.

@clemens-tolboom

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

I can't stop watching the car taking bumps. Too much pressure on the springs :-)

@nrsyed

This comment has been minimized.

Copy link
Owner

commented Aug 12, 2019

I can't stop watching the car taking bumps. Too much pressure on the springs :-)

Ha, it is nice, isn't it?

@nrsyed nrsyed merged commit 34d708e into nrsyed:master Aug 12, 2019

@clemens-tolboom

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

Thanks!

@clemens-tolboom clemens-tolboom deleted the clemens-tolboom:feature/add-road-types branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.