From 06f334d7cefcdafd96e47f6ddfb47181849cf02a Mon Sep 17 00:00:00 2001
From: Craigory Coppola <craigorycoppola@gmail.com>
Date: Tue, 10 Jan 2023 10:51:07 -0500
Subject: [PATCH] fix(core): run-one should not log undefined as target name on
 failure (#14238)

Fixes https://github.com/nrwl/nx/issues/14158
---
 packages/nx/src/command-line/run-many.spec.ts        | 12 ------------
 packages/nx/src/command-line/run-many.ts             |  8 +++-----
 .../dynamic-run-one-terminal-output-life-cycle.ts    |  6 +++---
 packages/nx/src/utils/command-line-utils.ts          |  1 -
 4 files changed, 6 insertions(+), 21 deletions(-)

diff --git a/packages/nx/src/command-line/run-many.spec.ts b/packages/nx/src/command-line/run-many.spec.ts
index ca44bcdde896d..dcca4bfa7c6fd 100644
--- a/packages/nx/src/command-line/run-many.spec.ts
+++ b/packages/nx/src/command-line/run-many.spec.ts
@@ -71,18 +71,6 @@ describe('run-many', () => {
       expect(projects).toContain('proj2');
     });
 
-    it('should throw for invalid patterns', () => {
-      expect(() => {
-        projectsToRun(
-          {
-            targets: ['test'],
-            projects: ['nomatch*'],
-          },
-          projectGraph
-        ).map(({ name }) => name);
-      }).toThrow();
-    });
-
     it('should exclude projects', () => {
       const projects = projectsToRun(
         {
diff --git a/packages/nx/src/command-line/run-many.ts b/packages/nx/src/command-line/run-many.ts
index 136008925ea07..76ce7d762ddf3 100644
--- a/packages/nx/src/command-line/run-many.ts
+++ b/packages/nx/src/command-line/run-many.ts
@@ -82,16 +82,14 @@ export function projectsToRun(
 
     if (invalidProjects.length > 0) {
       output.warn({
-        title: `the following do not have configuration for "${nxArgs.target}"`,
+        title: `The following projects do not have a configuration for any of the provided targets ("${nxArgs.targets.join(
+          ', '
+        )}")`,
         bodyLines: invalidProjects.map((name) => `- ${name}`),
       });
     }
   }
 
-  if (selectedProjects.size === 0) {
-    throw new Error(`No projects found for project patterns`);
-  }
-
   const excludedProjects = findMatchingProjects(
     nxArgs.exclude ?? [],
     Array.from(selectedProjects.keys()),
diff --git a/packages/nx/src/tasks-runner/life-cycles/dynamic-run-one-terminal-output-life-cycle.ts b/packages/nx/src/tasks-runner/life-cycles/dynamic-run-one-terminal-output-life-cycle.ts
index 4cd3a207e2c5f..5ec8b2d140c56 100644
--- a/packages/nx/src/tasks-runner/life-cycles/dynamic-run-one-terminal-output-life-cycle.ts
+++ b/packages/nx/src/tasks-runner/life-cycles/dynamic-run-one-terminal-output-life-cycle.ts
@@ -39,7 +39,7 @@ export async function createRunOneDynamicOutputRenderer({
 }: {
   initiatingProject: string;
   tasks: Task[];
-  args: { target?: string; configuration?: string; parallel?: number };
+  args: { configuration?: string; parallel?: number };
   overrides: Record<string, unknown>;
 }): Promise<{ lifeCycle: LifeCycle; renderIsDone: Promise<void> }> {
   cliCursor.hide();
@@ -79,7 +79,7 @@ export async function createRunOneDynamicOutputRenderer({
   const totalDependentTasksNotFromInitiatingProject =
     totalTasks - totalTasksFromInitiatingProject;
 
-  const targetName = args.target;
+  const targetName = tasks[0].target.target;
 
   let dependentTargetsNumLines = 0;
   let totalCompletedTasks = 0;
@@ -274,7 +274,7 @@ export async function createRunOneDynamicOutputRenderer({
 
       const text = `Successfully ran ${formatTargetsAndProjects(
         [initiatingProject],
-        [tasks[0].target.target],
+        [targetName],
         tasks
       )}`;
 
diff --git a/packages/nx/src/utils/command-line-utils.ts b/packages/nx/src/utils/command-line-utils.ts
index eed9b713569f3..993631d25da1b 100644
--- a/packages/nx/src/utils/command-line-utils.ts
+++ b/packages/nx/src/utils/command-line-utils.ts
@@ -11,7 +11,6 @@ export interface RawNxArgs extends NxArgs {
 }
 
 export interface NxArgs {
-  target?: string;
   targets?: string[];
   configuration?: string;
   runner?: string;