From 32f6552d75fbb32a16a825f2dc242b9913c32802 Mon Sep 17 00:00:00 2001 From: Adam Wootton Date: Mon, 26 Jun 2023 14:41:57 -0400 Subject: [PATCH] fix(js): workspace lib dependencies should not be added to package.json when listed in devDependencies --- packages/js/src/utils/package-json/update-package-json.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/js/src/utils/package-json/update-package-json.ts b/packages/js/src/utils/package-json/update-package-json.ts index f78972a0e8208..fccf15bddaae2 100644 --- a/packages/js/src/utils/package-json/update-package-json.ts +++ b/packages/js/src/utils/package-json/update-package-json.ts @@ -134,8 +134,13 @@ function addMissingDependencies( packageJson[propType][packageName] = version; } else { const packageName = entry.name; + if (!!workspacePackageJson.devDependencies?.[packageName]) { + return; + } + if ( !packageJson.dependencies?.[packageName] && + !packageJson.devDependencies?.[packageName] && !packageJson.peerDependencies?.[packageName] ) { const outputs = getOutputsForTargetAndConfiguration(