From 3d86de737345ea6f245e9b29cf520a87397fe7e0 Mon Sep 17 00:00:00 2001 From: Max Kless Date: Tue, 16 Apr 2024 15:57:55 +0200 Subject: [PATCH] fix(core): cleanup leftover code --- graph/client/src/app/routes.tsx | 121 ------------------ packages/nx/src/command-line/graph/graph.ts | 1 - .../file-watching/file-watcher-sockets.ts | 2 - .../project-json/build-nodes/project-json.ts | 7 +- 4 files changed, 1 insertion(+), 130 deletions(-) diff --git a/graph/client/src/app/routes.tsx b/graph/client/src/app/routes.tsx index f0f61053d4e99b..9b247bba98d915 100644 --- a/graph/client/src/app/routes.tsx +++ b/graph/client/src/app/routes.tsx @@ -54,127 +54,6 @@ const workspaceDataLoader = async (selectedWorkspaceId: string) => { const sourceMaps = await sourceMapsLoader(selectedWorkspaceId); - const placeholderErrors: GraphError[] = [ - { - message: 'Placeholder Error 1', - stack: - 'Placeholder Error Stack 1\n' + - ' at function1 (file1.ts:10)\n' + - ' at function2 (file2.ts:20)\n' + - ' at function3 (file3.ts:30)\n' + - ' at function4 (file4.ts:40)\n' + - ' at function5 (file5.ts:50)\n' + - ' at function6 (file6.ts:60)\n' + - ' at function7 (file7.ts:70)\n' + - ' at function8 (file8.ts:80)\n' + - ' at function9 (file9.ts:90)\n' + - ' at function10 (file10.ts:100)\n' + - ' at function11 (file11.ts:110)\n' + - ' at function12 (file12.ts:120)\n' + - ' at function13 (file13.ts:130)\n' + - ' at function14 (file14.ts:140)\n' + - ' at function15 (file15.ts:150)\n' + - ' at function16 (file16.ts:160)\n' + - ' at function17 (file17.ts:170)\n' + - ' at function18 (file18.ts:180)\n' + - ' at function19 (file19.ts:190)\n' + - ' at function20 (file20.ts:200)\n' + - ' at function21 (file21.ts:210)\n' + - ' at function22 (file22.ts:220)\n' + - ' at function23 (file23.ts:230)\n' + - ' at function24 (file24.ts:240)\n' + - ' at function25 (file25.ts:250)\n' + - ' at function26 (file26.ts:260)\n' + - ' at function27 (file27.ts:270)\n' + - ' at function28 (file28.ts:280)\n' + - ' at function29 (file29.ts:290)\n' + - ' at function30 (file30.ts:300)\n' + - ' at function31 (file31.ts:310)\n' + - ' at function32 (file32.ts:320)\n' + - ' at function33 (file33.ts:330)\n' + - ' at function34 (file34.ts:340)\n' + - ' at function35 (file35.ts:350)\n' + - ' at function36 (file36.ts:360)\n' + - ' at function37 (file37.ts:370)\n' + - ' at function38 (file38.ts:380)\n' + - ' at function39 (file39.ts:390)\n' + - ' at function40 (file40.ts:400)\n' + - ' at function41 (file41.ts:410)\n' + - ' at function42 (file42.ts:420)\n' + - ' at function43 (file43.ts:430)\n' + - ' at function44 (file44.ts:440)\n' + - ' at function45 (file45.ts:450)\n' + - ' at function46 (file46.ts:460)\n' + - ' at function47 (file47.ts:470)\n' + - ' at function48 (file48.ts:480)\n' + - ' at function49 (file49.ts:490)\n' + - ' at function50 (file50.ts:500)\n' + - ' at function51 (file51.ts:510)\n' + - ' at function52 (file52.ts:520)\n' + - ' at function53 (file53.ts:530)\n' + - ' at function54 (file54.ts:540)\n' + - ' at function55 (file55.ts:550)\n' + - ' at function56 (file56.ts:560)\n' + - ' at function57 (file57.ts:570)\n' + - ' at function58 (file58.ts:580)\n' + - ' at function59 (file59.ts:590)\n' + - ' at function60 (file60.ts:600)\n' + - ' at function61 (file61.ts:610)\n' + - ' at function62 (file62.ts:620)\n' + - ' at function63 (file63.ts:630)\n' + - ' at function64 (file64.ts:640)\n' + - ' at function65 (file65.ts:650)\n' + - ' at function66 (file66.ts:660)\n' + - ' at function67 (file67.ts:670)\n' + - ' at function68 (file68.ts:680)\n' + - ' at function69 (file69.ts:690)\n' + - ' at function70 (file70.ts:700)\n' + - ' at function71 (file71.ts:710)\n' + - ' at function72 (file72.ts:720)\n' + - ' at function73 (file73.ts:730)\n' + - ' at function74 (file74.ts:740)\n' + - ' at function75 (file75.ts:750)\n' + - ' at function76 (file76.ts:760)\n' + - ' at function77 (file77.ts:770)\n' + - ' at function78 (file78.ts:780)\n' + - ' at function79 (file79.ts:790)\n' + - ' at function80 (file80.ts:800)\n' + - ' at function81 (file81.ts:810)\n' + - ' at function82 (file82.ts:820)\n' + - ' at function83 (file83.ts:830)\n' + - ' at function84 (file84.ts:840)\n' + - ' at function85 (file85.ts:850)\n' + - ' at function86 (file86.ts:860)\n' + - ' at function87 (file87.ts:870)\n' + - ' at function88 (file88.ts:880)\n' + - ' at function89 (file89.ts:890)\n' + - ' at function90 (file90.ts:900)\n' + - ' at function91 (file91.ts:910)\n' + - ' at function92 (file92.ts:920)\n' + - ' at function93 (file93.ts:930)\n' + - ' at function94 (file94.ts:940)\n' + - ' at function95 (file95.ts:950)\n' + - ' at function96 (file96.ts:960)\n' + - ' at function97 (file97.ts:970)\n' + - ' at function98 (file98.ts:980)\n' + - ' at function99 (file99.ts:990)\n' + - ' at function100 (file100.ts:1000)\n', - cause: null, - name: 'Placeholder Error Name 1', - pluginName: 'Placeholder Error Plugin Name 1', - fileName: 'Placeholder Error File Name 1', - }, - { - message: 'Placeholder Error 2', - stack: 'Placeholder Error Stack 2', - cause: null, - name: 'Placeholder Error Name 2', - pluginName: 'Placeholder Error Plugin Name 2', - fileName: 'Placeholder Error File Name 2', - }, - // Add more placeholder errors as needed - ]; - return { ...projectGraph, targets, sourceMaps }; }; diff --git a/packages/nx/src/command-line/graph/graph.ts b/packages/nx/src/command-line/graph/graph.ts index dc82ae10ddfc65..4c5bc024cbdd0b 100644 --- a/packages/nx/src/command-line/graph/graph.ts +++ b/packages/nx/src/command-line/graph/graph.ts @@ -251,7 +251,6 @@ export async function generateGraph( }, affectedProjects: string[] ): Promise { - output.bold('Nx - Graph Workspace'); if ( Array.isArray(args.targets) && args.targets.length > 1 && diff --git a/packages/nx/src/daemon/server/file-watching/file-watcher-sockets.ts b/packages/nx/src/daemon/server/file-watching/file-watcher-sockets.ts index 4378bb21ff9e09..453010d913bc9a 100644 --- a/packages/nx/src/daemon/server/file-watching/file-watcher-sockets.ts +++ b/packages/nx/src/daemon/server/file-watching/file-watcher-sockets.ts @@ -1,12 +1,10 @@ import { Socket } from 'net'; import { findMatchingProjects } from '../../../utils/find-matching-projects'; -import { ProjectGraph } from '../../../config/project-graph'; import { findAllProjectNodeDependencies } from '../../../utils/project-graph-utils'; import { PromisedBasedQueue } from '../../../utils/promised-based-queue'; import { currentProjectGraph } from '../project-graph-incremental-recomputation'; import { handleResult } from '../server'; import { getProjectsAndGlobalChanges } from './changed-projects'; -import { serverLogger } from '../logger'; const queue = new PromisedBasedQueue(); diff --git a/packages/nx/src/plugins/project-json/build-nodes/project-json.ts b/packages/nx/src/plugins/project-json/build-nodes/project-json.ts index 5ffbcbfc652e47..14c6c5acf9a65c 100644 --- a/packages/nx/src/plugins/project-json/build-nodes/project-json.ts +++ b/packages/nx/src/plugins/project-json/build-nodes/project-json.ts @@ -12,13 +12,8 @@ export const ProjectJsonProjectsPlugin: NxPluginV2 = { '{project.json,**/project.json}', (file, _, { workspaceRoot }) => { let json: ProjectConfiguration; - // try { json = readJsonFile(join(workspaceRoot, file)); - // } catch (e) { - // throw new Error(`Failed to parse project.json file at ${file}`, { - // cause: e, - // }); - // } + const project = buildProjectFromProjectJson(json, file); return { projects: {