From 40d9901fa53a1c270f2c654b374a8f55f72dab9c Mon Sep 17 00:00:00 2001 From: Katerina Skroumpelou Date: Wed, 6 Jul 2022 15:44:53 +0300 Subject: [PATCH] cleanup(storybook): remove optional chaining and add warning log for targets (#11035) --- .../change-storybook-targets/change-storybook-targets.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/storybook/src/generators/change-storybook-targets/change-storybook-targets.ts b/packages/storybook/src/generators/change-storybook-targets/change-storybook-targets.ts index 41b5f1cbe7b8e..252eca162e5c1 100644 --- a/packages/storybook/src/generators/change-storybook-targets/change-storybook-targets.ts +++ b/packages/storybook/src/generators/change-storybook-targets/change-storybook-targets.ts @@ -62,7 +62,8 @@ function updateStorybookTarget( storybookBuildTarget: string ): TargetConfiguration { const oldStorybookTargetConfig: TargetConfiguration = - projectConfiguration?.targets?.[storybookTarget]; + projectConfiguration.targets[storybookTarget]; + const newStorybookTargetConfig: TargetConfiguration = { executor: '@storybook/angular:start-storybook', options: { @@ -109,7 +110,11 @@ function updateStorybookBuildTarget( storybookBuildTarget: string ): TargetConfiguration { const oldStorybookBuildTargetConfig: TargetConfiguration = - projectConfiguration?.targets?.[storybookBuildTarget]; + projectConfiguration.targets[storybookBuildTarget]; + if (!oldStorybookBuildTargetConfig?.options) { + logger.warn(`Could not find a Storybook build target for ${projectName}.`); + return; + } const newStorybookBuildTargetConfig: TargetConfiguration = { executor: '@storybook/angular:build-storybook', outputs: oldStorybookBuildTargetConfig.outputs,