Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): semver regex update #10416

Merged
merged 1 commit into from Jun 4, 2022
Merged

fix(js): semver regex update #10416

merged 1 commit into from Jun 4, 2022

Conversation

Zamiell
Copy link
Contributor

@Zamiell Zamiell commented May 21, 2022

The regex in the script is bugged and won't properly match 1.0.10, for example.

@nx-cloud
Copy link

nx-cloud bot commented May 21, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 56908f8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 4, 2022 at 4:21AM (UTC)

@Zamiell Zamiell changed the title bugfix for publish script fix(utils): semver regex update May 21, 2022
@Zamiell
Copy link
Contributor Author

Zamiell commented May 22, 2022

I'm not sure how a 1 character PR would make all these tests break, so I suspect this isn't my fault.

@nartc nartc changed the title fix(utils): semver regex update fix(js): semver regex update Jun 4, 2022
@nartc
Copy link
Contributor

nartc commented Jun 4, 2022

@Zamiell commit lint failed your build. I reworded the commit and also rebased to kick off a re-build. It should be good now.

PS: not sure how you got passed the commitlint on prepush 😅

@nartc nartc enabled auto-merge (squash) June 4, 2022 04:48
@nartc nartc merged commit c0a0f16 into nrwl:master Jun 4, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants