New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storybook): add support for basic test-runner configuration #11101
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Looks good in general! Once you mark this as ready, I'll add my comments! Thank you so much for this PR @Djiit !! :) :) |
@mandarini Thanks, please add any comments, I'll work on it asap :) |
Hey @Djiit ! Thank you so much for this PR! I made some changes, and I'll merge, if that's ok with you! :) Changes I made:
Other than that, all was perfect! Thank you so so much for contributing!!! |
Oh, I do have one small request! Can you change the PR description, and describe in a sentence (no more than 10-20 words) what you did? eg. added support to generate test-storybook target using test-runner, and a link to the relevant Storybook docs (test-runner docs or what not)? Thank you so much! This helps us later keep better track of what PRs do, and update any docs!! |
Here you are :) Feel free to ping me if you need more edits. Thanks for all the work! |
@Djiit @mandarini hello thanks for doing this! How would I go about using this and adding test-runner to a project? Thanks! |
THanks @mandarini, one more quick question, can I add this to an existing lib that has storybook already setup? |
You can try generating storybook configuration for that library again, yes. not sure if it will add the target. if it doesn't, try adding it in a new library, and then copy the task from project.json |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Added support to generate storybook test-runner target (https://storybook.js.org/docs/react/writing-tests/test-runner).
Related Issue(s)
Fixes #11047