Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add report-unused-disable-directives options for eslint plugin #11212

Closed
1 task done
peterreisz opened this issue Jul 19, 2022 · 2 comments · Fixed by #11272
Closed
1 task done

Add report-unused-disable-directives options for eslint plugin #11212

peterreisz opened this issue Jul 19, 2022 · 2 comments · Fixed by #11272
Labels
community This is a good first issue for contributing outdated scope: linter Issues related to Eslint support in Nx type: feature

Comments

@peterreisz
Copy link
Contributor

Add option to control the given settings via plugin option:
https://eslint.org/docs/latest/user-guide/command-line-interface#--report-unused-disable-directives

Description

Increase code quality by removing unused disable directives

Motivation

Increase code quality

Suggested Implementation

Update the option mapping here:
https://github.com/nrwl/nx/blob/master/packages/linter/src/executors/eslint/utility/eslint-utils.ts#L44

reportUnusedDisableDirectives: options.reportUnusedDisableDirectives

Also update the option interface
@AgentEnder AgentEnder added the scope: linter Issues related to Eslint support in Nx label Jul 19, 2022
@meeroslav
Copy link
Contributor

Thank you for this suggestion @peterreisz.

Please go ahead and create a PR with this improvement!

@meeroslav meeroslav added the community This is a good first issue for contributing label Jul 20, 2022
@peterreisz peterreisz mentioned this issue Jul 24, 2022
Merged
meeroslav pushed a commit that referenced this issue Aug 9, 2022
@peterreisz
feat(linter): add option to set report unused disabled directives (#1…
36f9420 
…1212) (#11272)

Co-authored-by: Peter Reisz <peter.reisz@mozaiq.app>
rlindgren pushed a commit to rlindgren/nx that referenced this issue Aug 11, 2022
@peterreisz @rlindgren
feat(linter): add option to set report unused disabled directives (nr…
7c77cfc 
…wl#11212) (nrwl#11272)

Co-authored-by: Peter Reisz <peter.reisz@mozaiq.app>
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
community This is a good first issue for contributing outdated scope: linter Issues related to Eslint support in Nx type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(linter): add option to set report unused disabled directives (#11212)
3 participants
@meeroslav @AgentEnder @peterreisz