Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): restore path in update-jestconfig #11457

Merged

Conversation

unpunnyfuns
Copy link
Contributor

Reverts what looks like a search and replace gone awry.

Current Behavior

Sets a Jest project path to <rootDir>/$"14.4.0-beta.5"root}

Expected Behavior

Reverts to the original path, <rootDir>/${project.root}

@vercel
Copy link

vercel bot commented Aug 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Aug 4, 2022 at 8:22PM (UTC)

@barbados-clemens barbados-clemens self-assigned this Aug 5, 2022
@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Aug 5, 2022
@barbados-clemens barbados-clemens merged commit 95e579b into nrwl:master Aug 5, 2022
@unpunnyfuns unpunnyfuns deleted the fix-jest-update-generator branch August 6, 2022 19:38
rlindgren pushed a commit to rlindgren/nx that referenced this pull request Aug 11, 2022
Co-authored-by: Pål Nes <pal.nes@fotoware.com>
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants