Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): skip projects configured in package.json for adding schemas #11742

Merged
merged 1 commit into from Aug 26, 2022

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

Having projects configured with something that is not project.json will cause the migration to fail.

Expected Behavior

Projects configured with something that is not project.json will be skipped during the migration.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Aug 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Aug 26, 2022 at 7:08PM (UTC)

@rhermes62
Copy link

rhermes62 commented Nov 1, 2022

Edit: Its actually a lerna issue, see here for more details. Please ignore original comment

> Having projects configured with something that is not project.json will cause the migration to fail.

@FrozenPandaz do you have more details on what migration was failing that necessitated this change?

I think this change ended up causing the issue reported here.

Lerna documentation recommends nx configurations in package.json which I think this broke:

* https://lerna.js.org/docs/concepts/how-caching-works#what-is-cached
* https://lerna.js.org/docs/api-reference/configuration#project-specific-configuration

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants