Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): remove double normalize of project name #11819 #11822

Merged
merged 1 commit into from Sep 1, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Sep 1, 2022

Current Behavior

We were adding a secondary normalization of the project name when generating a standalone component for a standalone library when a directory was passed. This caused an unexpected error by adding the directory name again.

Expected Behavior

Should generate a standalone library with component with no errors when a directory is passed

Related Issue(s)

Fixes #11819

@Coly010 Coly010 self-assigned this Sep 1, 2022
@vercel
Copy link

vercel bot commented Sep 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Sep 1, 2022 at 10:02AM (UTC)

@Coly010 Coly010 merged commit f51c1be into nrwl:master Sep 1, 2022
@Coly010 Coly010 deleted the 11819-lib-dir-standalone-error branch September 1, 2022 11:24
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate library with standalone component doesn't work IF "directory" field is filled
1 participant