Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): warning logged when generating MF app with no e2e #11911

Merged
merged 1 commit into from Sep 8, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Sep 7, 2022

Current Behavior

We log an incorrect warning when setting up MF for an app that intentionally has no e2e

Expected Behavior

Do not log warning

@Coly010 Coly010 self-assigned this Sep 7, 2022
@vercel
Copy link

vercel bot commented Sep 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Sep 8, 2022 at 8:22AM (UTC)

packages/angular/src/generators/host/host.ts Outdated Show resolved Hide resolved
packages/angular/src/generators/host/host.ts Outdated Show resolved Hide resolved
packages/angular/src/generators/remote/remote.ts Outdated Show resolved Hide resolved
@Coly010 Coly010 merged commit 4aa7282 into nrwl:master Sep 8, 2022
@Coly010 Coly010 deleted the angular/fix-mf-app-e2e branch September 8, 2022 08:44
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants