Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): Export remoteGenerator #12563

Merged
merged 1 commit into from Oct 26, 2022
Merged

Conversation

nikolaidk
Copy link
Contributor

@nikolaidk nikolaidk commented Oct 13, 2022

hostGenerator is all ready exported and is part for same context as remoteGenerator. Need remoteGenerator for customizing and testing remotes in workspace. This is allready done in the angular plugin, but not in react.

hostGenerator is all ready exported and is part for same context as remoteGenerator. Need remoteGenerator for customizing and testing remotes in workspace.
@nx-cloud-staging
Copy link

nx-cloud-staging bot commented Oct 13, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4be1618. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx-cloud record -- yarn check-commit
✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Oct 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Oct 13, 2022 at 7:27AM (UTC)

@nikolaidk nikolaidk changed the title Export remoteGenerator fix(react): Export remoteGenerator Oct 13, 2022
@nikolaidk
Copy link
Contributor Author

Fixed. Didn't add scope to subject on pr.

@FrozenPandaz FrozenPandaz merged commit 6e97c6c into nrwl:master Oct 26, 2022
@FrozenPandaz
Copy link
Collaborator

Thank you for your contribution! LGTM 🎉

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants