Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): improve wildcard import parsing to allow full regex #12877

Merged
merged 1 commit into from Oct 28, 2022

Conversation

meeroslav
Copy link
Contributor

Current Behavior

We map every * to .* which might turn a valid regex (e.g. react.*) into an invalid one.

Expected Behavior

Replace function should not destroy valid any char expression.

Related Issue(s)

Fixes #

@meeroslav meeroslav added the scope: linter Issues related to Eslint support in Nx label Oct 28, 2022
@meeroslav meeroslav self-assigned this Oct 28, 2022
@vercel
Copy link

vercel bot commented Oct 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Oct 28, 2022 at 1:31PM (UTC)

@meeroslav meeroslav enabled auto-merge (squash) October 28, 2022 13:30
@meeroslav meeroslav merged commit 758956d into nrwl:master Oct 28, 2022
@meeroslav meeroslav deleted the fix-linter-parse-import-wildcards branch November 8, 2022 15:34
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: linter Issues related to Eslint support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant