Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): update ngrx parent description to give better info about standalone api usage #16755

Merged

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented May 4, 2023

Current Behavior

With Angular 16, there is a new app.config.ts file that registers the providers for the bootstrapApplication call.
This is the new expected parent for the root state of NgRx generator.

However, the description on the option does not indicate this.

Expected Behavior

Update the description to reflect this change.
Add a some examples of the standalone api usage

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from leosvelperez as a code owner May 4, 2023 09:29
@Coly010 Coly010 self-assigned this May 4, 2023
@vercel
Copy link

vercel bot commented May 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2023 9:33am

@Coly010 Coly010 merged commit 0a81c64 into nrwl:master May 4, 2023
@Coly010 Coly010 deleted the angular/update-ngrx-options-description branch May 4, 2023 10:11
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants