Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron support #1975

Open
bennymeg opened this issue Oct 20, 2019 · 10 comments
Open

Electron support #1975

bennymeg opened this issue Oct 20, 2019 · 10 comments
Assignees

Comments

@bennymeg
Copy link

@bennymeg bennymeg commented Oct 20, 2019

Hi,
I would like to contribute Electron schematic to Nx .

Before I start, I want to make sure you have not started to work on something like that and to ask your permission to start working on it.

I went through the majority of the code (which is pretty cool, I most say) and I believe I can implement the schematic with ease based on your other schematics.

Benny.

@vsavkin

This comment has been minimized.

Copy link
Collaborator

@vsavkin vsavkin commented Oct 23, 2019

That's awesome. We aren't working on the electron support. So it would be great if you did it.

We are trying to contain the growth of the nrwl/nx repo for a few reasons: it's hard for us to guarantee the ease of upgrade if the number of packages keeps growing, and it makes the repo harder to manage. That's why we are encourage folks create Nx plugins in separate repos. We will still help you put it together, and will list it on the Nx readme and on nx.dev. What do you think?

@vsavkin vsavkin self-assigned this Oct 23, 2019
@bennymeg

This comment has been minimized.

Copy link
Author

@bennymeg bennymeg commented Oct 27, 2019

That's great,
I will start working on it soon and I will keep you updated when it will be done.
I will try to keep the development style and guideline as close as possible so people that are familiar with nx code could understand it quickly and in case you would like to include it in the future.

do you have a preferred prefix for the package? I am thinking using something similar to Angular's ngx- prefix. how about nx-electron?

@bennymeg

This comment has been minimized.

Copy link
Author

@bennymeg bennymeg commented Nov 23, 2019

Hi,
quick update,

I have implemented schematics for electron applications in a package named Nx Electron.
I would love to hear everybody's opinions.

Benny.

@vsavkin

This comment has been minimized.

Copy link
Collaborator

@vsavkin vsavkin commented Dec 3, 2019

@bennymeg that's great. I'll definitely check it out. I'll try to do it this week.

@FrozenPandaz

This comment has been minimized.

Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented Dec 6, 2019

Wow this is great!

Awesome job @bennymeg!

I have a branch with it working here :)

https://github.com/FrozenPandaz/nx-examples/tree/electron

Very very excited to see where this goes!

@skorunka

This comment has been minimized.

Copy link

@skorunka skorunka commented Dec 20, 2019

This is something I'm eager for! Great job.

@megagru

This comment has been minimized.

Copy link

@megagru megagru commented Jan 15, 2020

Hi. Are there any release plans?

@bennymeg

This comment has been minimized.

Copy link
Author

@bennymeg bennymeg commented Jan 15, 2020

Yes, next month.

@vsavkin

This comment has been minimized.

Copy link
Collaborator

@vsavkin vsavkin commented Jan 26, 2020

Hey folks. Just wanted to let you know that Nx 8.12 will come with some tooling to make it easier to create and test Nx plugins. It should be out next week.

@bennymeg

This comment has been minimized.

Copy link
Author

@bennymeg bennymeg commented Jan 27, 2020

Sound great! I will check it out once it will be published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.