Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose verdaccio's generator on @nx/js public API #21500

Closed
1 task done
willgm opened this issue Feb 1, 2024 · 1 comment · Fixed by #24008
Closed
1 task done

Expose verdaccio's generator on @nx/js public API #21500

willgm opened this issue Feb 1, 2024 · 1 comment · Fixed by #24008
Assignees
@xiongemi
Labels
outdated scope: js type: feature

Comments

@willgm
Copy link

willgm commented Feb 1, 2024

Description

Currently the generator to setup Verdaccio local-registry cannot be imported via source code to be composed with other Nx plugins.

Motivation

I currently have a use case to do it in my company, and I don't see a reason to this generator not be used in a custom composition with others, as we can do with many others.

Suggested Implementation

Just export it on packages/js/src/index.ts:

export { setupVerdaccio } from './generators/setup-verdaccio/generator';
@xiongemi xiongemi mentioned this issue May 21, 2024
Merged
FrozenPandaz pushed a commit that referenced this issue May 22, 2024
@xiongemi
fix(js): export setup verdaccio generator (#24008)
ebb9233 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #21500
FrozenPandaz pushed a commit that referenced this issue May 23, 2024
@xiongemi @FrozenPandaz
fix(js): export setup verdaccio generator (#24008)
c19c1bf 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #21500

(cherry picked from commit ebb9233)
FrozenPandaz pushed a commit that referenced this issue May 23, 2024
@xiongemi @FrozenPandaz
fix(js): export setup verdaccio generator (#24008)
bd74a2b 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #21500

(cherry picked from commit ebb9233)
@github-actions GitHub Actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xiongemi xiongemi

Labels
outdated scope: js type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(js): export setup verdaccio generator xiongemi/nx
3 participants
@willgm @AgentEnder @xiongemi