fix(testing): fix generating cypress-project with no project specified #2965
Conversation
| @@ -49,7 +49,7 @@ function updateNxJson(options: CypressProjectSchema): Rule { | |||
| return updateJsonInTree<NxJson>('nx.json', (json) => { | |||
| json.projects[options.projectName] = { | |||
| tags: [], | |||
| implicitDependencies: [options.project], | |||
| implicitDependencies: options.project ? [options.project] : [], | |||
There was a problem hiding this comment.
To be consistent with other projects without implicitDependencies, I think it would be better to not have the option at all.
Currently, you can use a noop() rule in the default function.
There was a problem hiding this comment.
Would you not want to add the empty tags either in this case? So just don't execute the updateNxJson(...) method at all if no project is specified?
There was a problem hiding this comment.
After re-reading your message I am pretty positive that's what you meant so I went ahead and made the changes.
There was a problem hiding this comment.
Sorry, I was mistaken... you are right we do need the tags. The expected result should be:
"my-app-e2e": {
tags: []
},
devinshoemaker
force-pushed
the
fix-cypress-implicit-deps
branch
from
234c597
to
618c642
Compare
| @@ -111,7 +111,7 @@ export default function (options: CypressProjectSchema): Rule { | |||
| }), | |||
| generateFiles(options), | |||
| updateWorkspaceJson(options), | |||
| updateNxJson(options), | |||
| options.project ? updateNxJson(options) : noop(), | |||
There was a problem hiding this comment.
Sorry, we do need tags.
There was a problem hiding this comment.
Okay, I think it's working like you suggested. Let me know if it looks good or if you want some slightly different syntax or something.
devinshoemaker
force-pushed
the
fix-cypress-implicit-deps
branch
from
618c642
to
837cd6f
Compare
|
@FrozenPandaz do these changes match what you were expecting? Let me know if you need me to tweak anything else prior to merging. |
|
Sorry, you were right initially, we do need the
I was wrong about using the |
devinshoemaker
force-pushed
the
fix-cypress-implicit-deps
branch
from
837cd6f
to
66efe0c
Compare
|
@FrozenPandaz changes have been made, tests has been updated, and branch has been rebased. |
devinshoemaker
force-pushed
the
fix-cypress-implicit-deps
branch
from
66efe0c
to
98e9b92
Compare
vsavkin
force-pushed
the
master
branch
3 times, most recently
from
738e12c
to
d1679ce
Compare
devinshoemaker
force-pushed
the
fix-cypress-implicit-deps
branch
from
98e9b92
to
3263174
Compare
|
Thank you! |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior (This is the behavior we have today, before the PR is merged)
If a Cypress project is generated without a project specified then it will cause issues with the modified
nx.jsonbecause the projectsimplicitDependencieswill contain anull.Expected Behavior (This is the new behavior we can expect after the PR is merged)
I am able to generate a Cypress project without a project specified.
Issue