fix(storybook): path on Win for tsconfig location in angular.json #4080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juristr
force-pushed
the
fix-storybook-migration-win-paths
branch
from
2ea516d
to
5d92f64
Compare
vsavkin
reviewed
Nov 12, 2020
| tsConfigStorybook: path.join( | ||
| options.projectConfig.root, | ||
| '.storybook/tsconfig.json' | ||
| tsConfig: normalize(path.join(options.projectConfig.root, 'tsconfig.json')), |
There was a problem hiding this comment.
This is required because the project root has \\ in its path?
There was a problem hiding this comment.
no, there was an issue that Rares mentioned related to these paths on Windows. I'm working on a fix just now
There was a problem hiding this comment.
but to be precise, that specific line wouldn't probably need the normalize, I'm gonna remove it there
Nx Cloud ReportCI ran the following commands for commit 1bf5bf4. Click to see the status, the terminal output, and the build insights.
Sent with 💌 from NxCloud. |
juristr
force-pushed
the
fix-storybook-migration-win-paths
branch
from
5d92f64
to
fcd82e2
Compare
juristr
force-pushed
the
fix-storybook-migration-win-paths
branch
from
fcd82e2
to
1bf5bf4
Compare
rarmatei
approved these changes
Nov 13, 2020
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #3956