feat(react): migrate @nrwl/web:build to devkit #4646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrozenPandaz
force-pushed
the
migrate-web
branch
from
c5d4ee0
to
2ab39d4
Compare
FrozenPandaz
force-pushed
the
migrate-web
branch
2 times, most recently
from
ab1388e
to
7e395e2
Compare
jaysoo
reviewed
Feb 1, 2021
|
|
||
| if (!options.buildLibsFromSource) { | ||
| if (!options.buildLibsFromSource && context.target) { |
There was a problem hiding this comment.
Why the check for context.target? I don't see it being used in the block.
FrozenPandaz
force-pushed
the
migrate-web
branch
from
7e395e2
to
5d16daa
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
@nrwl/web:build uses angular devkit
Expected Behavior
@nrwl/web:build uses devkit
Related Issue(s)
Fixes #