fix(devkit): properly emit failures when converting nx executor #4866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit a0acc92. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
srnec
reviewed
Feb 23, 2021
| .then((result) => { | ||
| if (!result.done) { | ||
| subscriber.next(result.value); | ||
| prev = result; |
There was a problem hiding this comment.
this prev variable looks like to be not used anywhere
FrozenPandaz
force-pushed
the
fix-convert
branch
from
ccfa38c
to
a0acc92
Compare
|
Thanks a lot for fix. This caused me us a quite a headache. Any idea when this gets released? 🙏 |
FrozenPandaz
added a commit
that referenced
this pull request
Feb 24, 2021
This was referenced Mar 11, 2021
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Converted Nx Executors always emit
{ success: true }.Expected Behavior
Converted Nx Executors properly emit output events.
Related Issue(s)
Fixes #4860
Fixes #4725