Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): added encoding param in Tree.read() #5668

Merged
merged 2 commits into from May 18, 2021

Conversation

Phillip9587
Copy link
Contributor

@Phillip9587 Phillip9587 commented May 14, 2021

Current Behavior

  • in many places the toString() method needs to be used after Tree.read()

Expected Behavior

  • Tree.read() should have a optional encoding parameter similar to fs.readFile()

@vercel
Copy link

vercel bot commented May 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/3Yq8JwbwNkD6XAPo92JcTRMDU1jp
✅ Preview: https://nx-dev-git-fork-phillip9587-tree-support-format-nrwl.vercel.app

@nx-cloud
Copy link

nx-cloud bot commented May 14, 2021

Nx Cloud Report

CI ran the following commands for commit a3a0357. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected --target=build --parallel --max-parallel=3
#000000 nx affected --target=e2e
#000000 nx affected --target=lint --parallel --max-parallel=4
#000000 nx affected --target=test --parallel --max-parallel=2

Sent with 💌 from NxCloud.

@vsavkin
Copy link
Member

vsavkin commented May 18, 2021

Thank you

@vsavkin vsavkin merged commit 52e3083 into nrwl:master May 18, 2021
@Phillip9587 Phillip9587 deleted the tree-support-format branch September 21, 2022 11:56
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants