Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): make missing output check more comprehensive #6204

Merged
merged 1 commit into from Jul 1, 2021
Merged

fix(core): make missing output check more comprehensive #6204

merged 1 commit into from Jul 1, 2021

Conversation

kirjai
Copy link
Contributor

@kirjai kirjai commented Jun 30, 2021

Current Behavior

to determine whether any cached outputs are missing - nx only checks for presence of directories.

Expected Behavior

to determine whether any cached outputs are missing - nx should perform a more comprehensive check.


this PR adds a small additional check - whether the amount of files in two directories is the same. if not - that means that some output files are missing.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jun 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/BUnkzKNK4yjyrUrhys9AsKdadKfa
✅ Preview: Canceled

@vsavkin vsavkin merged commit e7a1cd2 into nrwl:master Jul 1, 2021
@kirjai kirjai deleted the vercel-improvement branch July 1, 2021 22:08
@statop
Copy link

statop commented Jul 19, 2021

this breaks the ability to specify file outputs - https://github.com/nrwl/nx/pull/3613/files

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants