Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): use next.js image types #6556

Merged
merged 1 commit into from Jul 30, 2021
Merged

fix(nextjs): use next.js image types #6556

merged 1 commit into from Jul 30, 2021

Conversation

kirjai
Copy link
Contributor

@kirjai kirjai commented Jul 30, 2021

Current Behavior

new next.js libs should use the new images.d.ts file that relies on "next/image-types/global"

Expected Behavior

Related Issue(s)

Fixes #6447

@vercel
Copy link

vercel bot commented Jul 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/D568iHpRN4rncgbfiaqB2yXp2dwW
✅ Preview: Canceled

@jaysoo jaysoo enabled auto-merge (squash) July 30, 2021 18:38
@jaysoo jaysoo merged commit e0a5dbf into nrwl:master Jul 30, 2021
@kirjai kirjai deleted the image-fix branch July 30, 2021 19:02
ManojBahuguna pushed a commit to ManojBahuguna/nx that referenced this pull request Sep 16, 2021
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

image.d.ts in @nrwl/react/typings provides wrong typing for Next.js project
2 participants