fix(angular): shared transitive npm deps from host and remote applica…

[yharaskrik]

…tions

Current Behavior

Currently when building MFEs with Nx if a remote has a transitive dependency on an npm lib that npm lib is not included in the shared libs when compiling with webpack.

Example:

Host AppModule imports:

// ngrx store
StoreModule.forRoot()

Remote AppModule imports:

SomeCustomStateModule

SomeCustomStateModule imports:

StoreModule.forFeature()

will result in a DI injection issue where the ReducerManager is not provided, this is because @ngrx/store is not shared.

Expected Behavior

Should shared all npm deps between the different MFEs

Related Issue(s)

Fixes #

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 29586f4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 13 targets

• nx affected --target=build --base=f7efef433cecc2de5aaa9a8d94d549f7f69484e0 --head=29586f40fcb170b776dfa6dac4486cc89c2096de --parallel=3
• nx affected --target=e2e --base=f7efef433cecc2de5aaa9a8d94d549f7f69484e0 --head=29586f40fcb170b776dfa6dac4486cc89c2096de --exclude=e2e-detox,e2e-js,e2e-next,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-cypress,e2e-node,e2e-linter,e2e-jest,e2e-a...
• nx affected --target=e2e --base=f7efef433cecc2de5aaa9a8d94d549f7f69484e0 --head=29586f40fcb170b776dfa6dac4486cc89c2096de --exclude=e2e-storybook,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=lint --base=f7efef433cecc2de5aaa9a8d94d549f7f69484e0 --head=29586f40fcb170b776dfa6dac4486cc89c2096de --parallel=3
• nx affected --target=test --base=f7efef433cecc2de5aaa9a8d94d549f7f69484e0 --head=29586f40fcb170b776dfa6dac4486cc89c2096de --parallel=1
• nx build typedoc-theme
• nx run-many --target=build --all --parallel=8 --exclude=docs,nx-dev-data-access-documents,nx-dev-e2e,nx-dev,nx-dev-feature-analytics,nx-dev-feature-conf,nx-dev-feature-doc-viewer,nx-dev-feature-search,nx-dev-feature-storage,nx-dev-feature-versions-and-flavors,nx-dev-ui-commands,nx-dev-ui-common,nx-dev-ui-home,nx-dev-ui-member-card,nx-dev-ui-sponsor...
• nx-cloud record -- yarn check-commit
• nx-cloud record -- yarn check-imports
• nx-cloud record -- yarn depcheck
• nx-cloud record -- yarn documentation
• nx-cloud record -- yarn nx format:check --base=f7efef433cecc2de5aaa9a8d94d549f7f69484e0 --head=29586f40fcb170b776dfa6dac4486cc89c2096de
• nx-cloud record -- yarn nx workspace-lint

---

Sent with 💌 from NxCloud.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
nx-dev	⬜️ Ignored (Inspect)		Apr 26, 2022 at 3:49PM (UTC)

[leosvelperez]

Thanks for the contribution!

It looks good to me, there's just a small issue to solve for which I left a suggestion for both plugins.

[yharaskrik]

Done and done @leosvelperez!

[leosvelperez]

LGTM! 🎉

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.