feat(testing): update to jest v24 #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait until |
|
Any chance to get a preview release? |
|
jest-preset-angular v7 is finally released. |
vsavkin
approved these changes
Mar 11, 2019
| ext === '.less' || | ||
| ext === '.styl' | ||
| ) { | ||
| return require.resolve('identity-obj-proxy'); |
There was a problem hiding this comment.
react apps expect styles to be an object when imported? Not totally sure.. @jaysoo has more info.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior (This is the behavior we have today, before the PR is merged)
jest-angular-presetis installed for projects without angularExpected Behavior (This is the new behavior we can expect after the PR is merged)
jest-angular-presetis not installed for projects without angular,ts-jestisIssue
Fixes #1029