Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx/react): wrong svg import processing #12477

merged 1 commit into from Dec 19, 2022


Copy link

@nglazov nglazov commented Oct 9, 2022

Current Behavior

webpack imports svg-files as js modules instead of resource when it is imported from style-files (css/scss/less/styl)

Expected Behavior

webpack imports file as a resource

Related Issue(s)


Fixes #

Copy link

nx-cloud-staging bot commented Oct 9, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 53ca2dd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

🟥 Failed Commands
nx-cloud record -- yarn nx format:check --base=080a8961d88456b39857d0d23ac8b51f8e0fda5e --head=53ca2dd54c7892ad5bfa2a9e1c83747b9957aad0
Successfully ran 3 targets

Sent with 💌 from NxCloud.

Copy link

vercel bot commented Oct 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 19, 2022 at 8:36PM (UTC)

@jaysoo jaysoo force-pushed the fix/svg-import-in-react-css branch 2 times, most recently from 08135b0 to 3360d30 Compare December 19, 2022 20:35
@jaysoo jaysoo merged commit 37dc336 into nrwl:master Dec 19, 2022
13 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants