Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): checks for targets existence before attempting to iterate them #13287

merged 1 commit into from Nov 21, 2022


Copy link

Current Behavior

Migration fails for projects that don't have a target section defined. (e.g.: an assets library which only holds static files and does not need to build/test/lint/etc. anything)

Expected Behavior

Projects without a target section should be omitted from running the migration, not throw an error.

Fixes #13286

Copy link

vercel bot commented Nov 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 21, 2022 at 1:15PM (UTC)

Copy link

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit 328c547 into nrwl:master Nov 21, 2022
13 checks passed
@ccosmincc ccosmincc deleted the fix/missing-targets-migration branch November 22, 2022 08:39
FrozenPandaz pushed a commit that referenced this pull request Nov 28, 2022
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

upgradeTypescriptTarget migration fails for projects which do not have any targets
2 participants