Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): remove karma test.ts file from generation #13356



Copy link

Current Behavior

A src/test.ts file is generated for apps and libs when using Karma as the test runner. This file is no longer needed to be generated by default since Angular provides it in memory with the same default content.

Expected Behavior

A src/test.ts file is not generated for apps and libs when using Karma as the test runner. Less boilerplate for the majority of cases.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Nov 23, 2022
Copy link

vercel bot commented Nov 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 23, 2022 at 5:09PM (UTC)

@leosvelperez leosvelperez marked this pull request as draft November 23, 2022 17:03
@leosvelperez leosvelperez marked this pull request as ready for review November 23, 2022 17:09
Copy link

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@leosvelperez leosvelperez merged commit a0d01b6 into nrwl:master Nov 24, 2022
13 checks passed
@leosvelperez leosvelperez deleted the angular/remove-karma-main-file branch November 24, 2022 11:33
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants