Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): add workaround for MF SSR #13372



Copy link

@Coly010 Coly010 commented Nov 24, 2022

Current Behavior

Angular 15 includes @angular/platform-server code as an entry point and as a loader. This is appended to the build in a manner that it is executed outside of the shared scope created by the Webpack Module Federation Plugin.

This breaks SSR for Module Federated applications.

Expected Behavior

The generated host and remote applications should include the code that is automatically included by the Angular Server Builder within the shared scope created by the Module Federation Plugin, and remove the auto-inclusion of this code from the webpack config that is used by the builder.

@Coly010 Coly010 self-assigned this Nov 24, 2022
Copy link

vercel bot commented Nov 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 24, 2022 at 11:14AM (UTC)

@Coly010 Coly010 merged commit 883b61b into nrwl:master Nov 24, 2022
13 checks passed
@Coly010 Coly010 deleted the angular/workaround-angular-server-builder branch November 24, 2022 11:59
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant