Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): standalone angular projects with karma should function #13626

merged 1 commit into from Dec 5, 2022


Copy link

@Coly010 Coly010 commented Dec 5, 2022

Current Behavior

We generate invalid karma config for new projects in a standalone workspace without taking into account what the base karma.conf.js has

Expected Behavior

We should check the style of syntax the base karma config is using to determine how to generate the karma config for the project.

@Coly010 Coly010 self-assigned this Dec 5, 2022
Copy link

vercel bot commented Dec 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 5, 2022 at 11:21AM (UTC)

@Coly010 Coly010 merged commit b4db6e8 into nrwl:master Dec 5, 2022
13 checks passed
@Coly010 Coly010 deleted the angular/standalone-karma-flow branch December 5, 2022 12:00
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants