Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): handle local workspace projects in package.json for affected locator #13728

merged 2 commits into from Dec 13, 2022


Copy link

Current Behavior

Workspace projects defined as dependencies in the package.json are not discovered by getTouchedNpmPackages since they don't exist on the externalNodes, causing affected command to fail.

Expected Behavior

Workspace projects defined as dependencies in the package.json should be discovered by getTouchedNpmPackages by looking at nodes and returned within touchedProjectLocators

Related Issue(s)

Fixes #13668

@meeroslav meeroslav added the scope: core core nx functionality label Dec 9, 2022
@meeroslav meeroslav self-assigned this Dec 9, 2022
Copy link

vercel bot commented Dec 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev Ready (Inspect) Visit Preview Dec 12, 2022 at 3:58PM (UTC)

Copy link

timfishercs commented Dec 12, 2022

I think potentially this code needs updating as well Error: Invalid project name is detected: "npmPackage"


Copy link
Contributor Author

@timfishercs, can you show me your npm-packages.js? The npmPackage is only used as a parameter name. I don't see how it could end up in touchedProjects in affected-project-graph.js.

@meeroslav meeroslav merged commit 65ecd9c into nrwl:master Dec 13, 2022
13 checks passed
FrozenPandaz pushed a commit that referenced this pull request Dec 19, 2022
@meeroslav meeroslav deleted the fix-13668 branch March 14, 2023 22:17
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
scope: core core nx functionality
None yet

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'name') when running nx affected
4 participants